Re: [PATCH v5 1/3] arm64: dts: qcom: x1e80100-vivobook-s15: Use the samsung,atna33xc20 panel driver

From: Johan Hovold
Date: Tue Dec 03 2024 - 03:38:16 EST


On Mon, Dec 02, 2024 at 07:18:11PM +0100, Maud Spierings via B4 Relay wrote:
> From: Maud Spierings <maud_spierings@xxxxxxxxxxx>
>
> The Asus vivobook s15 uses the ATNA56AC03 panel.
> This panel is controlled by the atna33xc20 driver instead of the generic
> edp-panel driver
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Signed-off-by: Maud Spierings <maud_spierings@xxxxxxxxxxx>

> +&pmc8380_3_gpios {
> + edp_bl_en: edp-bl-en-state {
> + pins = "gpio4";
> + function = "normal";
> + power-source = <1>;
> + qcom,drive-strength = <2>;

Please use the Qualcomm drive strength defines from
dt-bindings/pinctrl/qcom,pmic-gpio.h here (e.g. PMIC_GPIO_STRENGTH_MED).

> + bias-pull-down;
> + input-disable;
> + output-enable;
> + };
> +};

Johan