Re: [PATCH 2/9] dt-bindings: display: renesas,du: Add r8a779h0
From: Laurent Pinchart
Date: Tue Dec 03 2024 - 03:50:38 EST
On Tue, Dec 03, 2024 at 09:38:44AM +0100, Geert Uytterhoeven wrote:
> Hi Laurent,
>
> On Tue, Dec 3, 2024 at 9:19 AM Laurent Pinchart
> <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
> > On Tue, Dec 03, 2024 at 10:01:36AM +0200, Tomi Valkeinen wrote:
> > > From: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> > >
> > > Extend the Renesas DU display bindings to support the r8a779h0 V4M.
> > >
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx>
> > > ---
> > > Documentation/devicetree/bindings/display/renesas,du.yaml | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > index c5b9e6812bce..d369953f16f7 100644
> > > --- a/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml
> > > @@ -41,6 +41,7 @@ properties:
> > > - renesas,du-r8a77995 # for R-Car D3 compatible DU
> > > - renesas,du-r8a779a0 # for R-Car V3U compatible DU
> > > - renesas,du-r8a779g0 # for R-Car V4H compatible DU
> > > + - renesas,du-r8a779h0 # for R-Car V4M compatible DU
> > >
> > > reg:
> > > maxItems: 1
> >
> > You also need to add h0 to the g0 block in the conditional properties
> > below. With that,
>
> Which is not sufficient, as the DU on R-Car V4M has only a single channel,
> unlike on R-Car V3U and V4H.
Ah, indeed, in that case the DT bindings also need to take that into
account :-)
--
Regards,
Laurent Pinchart