Re: [PATCH v5 3/3] arm64: dts: qcom: x1e80100-vivobook-s15: Add bluetooth

[Maud Spierings]

On 12/3/24 9:52 AM, Johan Hovold wrote:
> On Mon, Dec 02, 2024 at 07:18:13PM +0100, Maud Spierings via B4 Relay wrote:
> > From: Maud Spierings <maud_spierings@xxxxxxxxxxx>
> >
> > Add bluetooth for the asus vivobook s15
> > Describe wlan configuration
> I assume you copied most of these (effectively boilerplate) definitions
> from somewhere so perhaps you can mention that here (e.g. if it was
> copied from Stephan's patches [1]).
will do
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Signed-off-by: Maud Spierings <maud_spierings@xxxxxxxxxxx>
> > ---
> >   .../boot/dts/qcom/x1e80100-asus-vivobook-s15.dts   | 163 +++++++++++++++++++++
> >   1 file changed, 163 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> > index 7269f8e7709988657b363004875163a69142f16c..0774bd65ae8cddab81b98e27a116fd5adbe1363c 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
> > @@ -18,6 +18,11 @@ / {
> >   	compatible = "asus,vivobook-s15", "qcom,x1e80100";
> >   	chassis-type = "laptop";
> >   
> > +	aliases {
> > +		serial0 = &uart21;
> No need to add an alias for the console port which is likely not
> accessible on this device (without some tinkering).
Yeah I did find it, there are some labeled probe points on the pcb plus 
a weird unused connector near it, I will remove it
> > +		serial1 = &uart14;
> > +	};
> > +
> >   	gpio-keys {
> >   		compatible = "gpio-keys";
> >   		pinctrl-0 = <&hall_int_n_default>;
> > +	wcn_bt_en: bt-en-state {
> Looks like you want a "wcn-" prefix on the node name here too.
will do
> > +		pins = "gpio116";
> > +		function = "gpio";
> > +		drive-strength = <16>;
> Is this the drive-strength the firmware uses? The default 2 should be
> enough, but you can leave it as-is if it matches the fw settings if you
> prefer.
This one I do not know, it is not turned on by the firmware, I assumed 
the same value as the two later ones
> > +		output-low;
> I don't think you should be setting the pin state already in the pin
> configuration as this should be left up to the driver to control.
Will remove
> > +		bias-pull-down;
> A pull-down should not be needed for this output either.
I pulled this from the DSDT, it was defined with a pull down there
> > +	};
> > +
> > +	wcn_sw_en: wcn-sw-en-state {
> > +		pins = "gpio214";
> > +		function = "gpio";
> > +		drive-strength = <16>;
> > +		bias-disable;
> > +	};
> > +
> > +	wcn_wlan_en: wlan-en-state {
> > +		pins = "gpio117";
> > +		function = "gpio";
> > +		drive-strength = <16>;
> > +		bias-disable;
> > +	};
> Same question about the drive strength applies to these two.
These two drive strengths were used by the device firmware, a lower one 
will probably work too but I thought it would be best to stick to those 
values
> > +};
> Johan
>
>
> [1] https://lore.kernel.org/all/20241007-x1e80100-pwrseq-qcp-v1-0-f7166510ab17@xxxxxxxxxx/