Re: [PATCH v2 09/22] wifi: ath12k: avoid m3 firmware download in AHB device IPQ5332

[Raj Kumar Bhagat]

On 10/19/2024 1:30 AM, Konrad Dybcio wrote:
> On 15.10.2024 8:26 PM, Raj Kumar Bhagat wrote:
>> From: Balamurugan S <quic_bselvara@xxxxxxxxxxx>
>>
>> Current ath12k devices, QCN9274 and WCN7850, supports m3.bin firmware
>> download through ath12k driver. The new ath12k AHB based device
>> IPQ5332 supports m3 firmware download through remoteproc driver.
>>
>> Hence, add new parameter (m3_fw_support) in ath12k_hw_params to avoid
>> m3 firmware download in IPQ5332.
>>
>> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1
>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00210-QCAHKSWPL_SILICONZ-1
>>
>> Signed-off-by: Balamurugan S <quic_bselvara@xxxxxxxxxxx>
>> Co-developed-by: P Praneesh <quic_ppranees@xxxxxxxxxxx>
>> Signed-off-by: P Praneesh <quic_ppranees@xxxxxxxxxxx>
>> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@xxxxxxxxxxx>
>> ---
>>  drivers/net/wireless/ath/ath12k/hw.c  |  8 ++++++++
>>  drivers/net/wireless/ath/ath12k/hw.h  |  2 ++
>>  drivers/net/wireless/ath/ath12k/qmi.c | 28 ++++++++++++++++-----------
>>  3 files changed, 27 insertions(+), 11 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/hw.c b/drivers/net/wireless/ath/ath12k/hw.c
>> index e5e2164c27d2..a4e0c21ac4b7 100644
>> --- a/drivers/net/wireless/ath/ath12k/hw.c
>> +++ b/drivers/net/wireless/ath/ath12k/hw.c
>> @@ -1299,6 +1299,8 @@ static const struct ath12k_hw_params ath12k_hw_params[] = {
>>  		.iova_mask = 0,
>>  
>>  		.supports_aspm = false,
>> +
>> +		.m3_fw_support = true,
> 
> 'support for m3 firmware' is not a fitting term.. maybe "needs_m3_fw"?
> 

The name "m3_fw_support" is inherited from ath11k, for ath12k we could
change it to "needs_m3_fw".