Re: [PATCH net] net/mlx5: DR, prevent potential error pointer dereference

From: Yevgeny Kliteynik
Date: Tue Dec 03 2024 - 05:14:44 EST


On 03-Dec-24 11:39, Dan Carpenter wrote:
On Tue, Dec 03, 2024 at 10:32:13AM +0100, Mateusz Polchlopek wrote:


On 11/30/2024 11:01 AM, Dan Carpenter wrote:
The dr_domain_add_vport_cap() function genereally returns NULL on error

Typo. Should be "generally"


Sure.

but sometimes we want it to return ERR_PTR(-EBUSY) so the caller can
retry. The problem here is that "ret" can be either -EBUSY or -ENOMEM

Please remove unnecessary space.


What are you talking about?

Oh, I see it :)
Double space between "retry." and "The"

-- YK

regards,
dan carpenter