Re: [PATCH 0/3] module: fixups after module namespace conversion

[Masahiro Yamada]

Hi Linus,


I submitted this patch set to you, hoping you can merge it.
Please let me know if you would prefer a different course.



On Tue, Dec 3, 2024 at 7:21 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
>
> [1/3]
> Commit cdd30ebb1b9f added double-quotes to enclose the variable in the
> semantic patch, scripts/coccinelle/misc/add_namespace.cocci.
> Since then, 'make nsdepds' always changes the missing import to silly code:
>    MODULE_IMPORT_NS("ns");
>
> [2/3]
> MODULE_IMPORT_NS("") is misleading in the context of documentation
> about MODULE_IMPORT_NS() tags in general.
>
> [3/3]
> Convert DEFAULT_SYMBOL_NAMESPACE from a macro expansion to a string
> literal. There is no good reason to keep inconsistency in the default
> case.
>
>
>
> Masahiro Yamada (3):
>   scripts/nsdeps: get 'make nsdeps' working again
>   doc: module: revert misconversions for MODULE_IMPORT_NS()
>   module: Convert default symbol namespace to string literal
>
>  Documentation/core-api/symbol-namespaces.rst              | 8 ++++----
>  .../translations/it_IT/core-api/symbol-namespaces.rst     | 8 ++++----
>  .../translations/zh_CN/core-api/symbol-namespaces.rst     | 8 ++++----
>  drivers/cdx/Makefile                                      | 2 +-
>  drivers/crypto/intel/iaa/Makefile                         | 2 +-
>  drivers/crypto/intel/qat/qat_common/Makefile              | 2 +-
>  drivers/dma/idxd/Makefile                                 | 2 +-
>  drivers/gpio/gpio-idio-16.c                               | 2 +-
>  drivers/hwmon/nct6775-core.c                              | 2 +-
>  drivers/i2c/busses/i2c-designware-common.c                | 2 +-
>  drivers/i2c/busses/i2c-designware-master.c                | 2 +-
>  drivers/i2c/busses/i2c-designware-slave.c                 | 2 +-
>  drivers/pwm/core.c                                        | 2 +-
>  drivers/pwm/pwm-dwc-core.c                                | 2 +-
>  drivers/pwm/pwm-lpss.c                                    | 2 +-
>  drivers/tty/serial/sc16is7xx.c                            | 2 +-
>  drivers/usb/storage/Makefile                              | 2 +-
>  include/linux/export.h                                    | 2 +-
>  scripts/coccinelle/misc/add_namespace.cocci               | 4 ++--
>  scripts/nsdeps                                            | 2 +-
>  20 files changed, 30 insertions(+), 30 deletions(-)
>
> --
> 2.43.0
>


-- 
Best Regards
Masahiro Yamada