Re: [PATCH v2 13/18] arm64: dts: mediatek: mt7988: add i2c to bpi-r4 board

[Frank Wunderlich (linux)]

Am 2024-12-03 15:22, schrieb AngeloGioacchino Del Regno:
> Il 03/12/24 11:58, Frank Wunderlich ha scritto:
> > Am 3. Dezember 2024 10:40:38 MEZ schrieb AngeloGioacchino Del Regno 
> > <angelogioacchino.delregno@xxxxxxxxxxxxx>:
> > > Il 02/12/24 13:25, Frank Wunderlich ha scritto:
> > > > From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > > >
> > > > Add basic i2c nodes to bananapi R4 board.
> > > >
> > > > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
> > >
> > > arm64: dts: mediatek: mt7988a-bpi-r4: Enable I2C controllers
> > >
> > > Enable the I2C0, I2C2 controllers found on the BananaPi R4 board; 
> > > these
> > > controllers are accessible at ... I don't know, a header on the 
> > > board?
> >
> > These 2 i2c have directly connected spare devices (pmic on i2c0 and 
> > i2c-mux on i2c2 added in later commits to have it a bit cleaner). I2c1 
> > is on gpio header which i have not added to let user choose if he 
> > wants i2c option or gpio. I can also add i2c1 to r4 board with the 
> > right pinctrl but imho it should be disabled to have gpio function 
> > default.
>
> And again, you should really add all that information to the commit 
> description,
> as that not only helps me to review your submission, but also helps 
> other people
> checking the commit history....!

this ine i would rephrase like this

    arm64: dts: mediatek: mt7988a-bpi-r4: Enable I2C controllers

    Enable the I2C0, I2C2 controllers found on the BananaPi R4 board.
    Both controllers are not accessible from user and having fixed spare
    devices. I2C0 have a pmic connected, I2C2 is used with 
I2C-multiplexer
    for e.g. SFP cages.
    The missing I2C1 is connected to GPIO header which can have either 
GPIO
    mode or I2C mode.


> Cheers
>
> > > After which,
> > >
> > > Reviewed-by: AngeloGioacchino Del Regno 
> > > <angelogioacchino.delregno@xxxxxxxxxxxxx>
> >
> >
> > regards Frank