Re: [PATCH v6 2/2] arm64: dts: qcom: sa8775p: Add support for clock controllers

[Taniya Das]

On 12/3/2024 9:02 PM, Bjorn Andersson wrote:
> On Tue, Dec 03, 2024 at 10:04:13AM +0530, Taniya Das wrote:
> > On 10/26/2024 12:12 AM, Konrad Dybcio wrote:
> > > On 25.10.2024 8:42 PM, Konrad Dybcio wrote:
> > > > On 25.10.2024 10:52 AM, Taniya Das wrote:
> > > > > Add support for video, camera, display0 and display1 clock controllers
> > > > > on SA8775P. The dispcc1 will be enabled based on board requirements.
> > >
> > > Actually, why would that be? CCF should park it gracefully with
> > > unused cleanup
> >
> > Yes, CCF should take care to cleanup. But I am of an opinion that as we are
> > aware that this platform do not require the dispcc1 so we could avoid the
> > clock driver initialization and help in boot KPI.
>
> Does that imply that we're guaranteed that the bootloader will never
> configure any clocks in dispcc1 that needs to be gracefully parked from
> the OS? Is this guaranteed to be the case for all QCS9100 boards?

Yes, bootloader will never use DISPCC1.

> IMHO we should default to correctness, and then make product-specific
> boot time optimizations from that starting point.

As I was sure it will not be used on this board, so I left it disabled.

> Regards,
> Bjorn
>
> > > Konrad
> > >
> > > > > Reviewed-by: Jagadeesh Kona <quic_jkona@xxxxxxxxxxx>
> > > > > Signed-off-by: Taniya Das <quic_tdas@xxxxxxxxxxx>
> > > > > ---
> > > >
> > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> > > >
> > > > Konrad
> >
> > --
> > Thanks & Regards,
> > Taniya Das.

--
Thanks & Regards,
Taniya Das.