Re: [PATCH 0/9] crypto: qce - refactor the driver

From: Eric Biggers
Date: Tue Dec 03 2024 - 13:32:38 EST


On Tue, Dec 03, 2024 at 09:35:03AM -0800, Eric Biggers wrote:
> On Tue, Dec 03, 2024 at 10:19:28AM +0100, Bartosz Golaszewski wrote:
> > This driver will soon be getting more features so show it some
> > refactoring love in the meantime. Switching to using a workqueue and
> > sleeping locks improves cryptsetup benchmark results for AES encryption.
>
> What is motivating this work? I thought this driver is useless because ARMv8 CE
> is an order of magnitude faster.
>

I see what might be happening. This driver registers its algorithms with too
high of a priority, which makes it get used when it shouldn't be. I've sent out
a patch to fix that.

- Eric