Re: [PATCH v7 07/12] platform/x86: hfi: add online and offline callback support

From: Mario Limonciello
Date: Tue Dec 03 2024 - 16:30:12 EST


On 12/2/2024 05:38, Peter Zijlstra wrote:
On Sat, Nov 30, 2024 at 08:06:58AM -0600, Mario Limonciello wrote:

@@ -340,6 +416,11 @@ static int amd_hfi_probe(struct platform_device *pdev)
if (ret)
return ret;
+ ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "x86/amd_hfi:online",
+ amd_hfi_online, amd_hfi_offline);

By using online notifier, you will already have tasks running on this
CPU before you initialize the HFI bits, is that okay?

Yeah; AFAICT it should be fine.