Re: [PATCH net-next v1 00/21] lan78xx: Preparations for PHYlink

From: Andrew Lunn
Date: Tue Dec 03 2024 - 16:58:39 EST


On Tue, Dec 03, 2024 at 08:21:33AM +0100, Oleksij Rempel wrote:
> This patch set is part of the preparatory work for migrating the lan78xx
> USB Ethernet driver to the PHYlink framework. During extensive testing,
> I observed that resetting the USB adapter can lead to various read/write
> errors. While the errors themselves are acceptable, they generate
> excessive log messages, resulting in significant log spam. This set
> improves error handling to reduce logging noise by addressing errors
> directly and returning early when necessary.
>
> Key highlights of this series include:
> - Enhanced error handling to reduce log spam while preserving the
> original error values, avoiding unnecessary overwrites.
> - Improved error reporting using the `%pe` specifier for better clarity
> in log messages.
> - Removal of redundant and problematic PHY fixups for LAN8835 and
> KSZ9031, with detailed explanations in the respective patches.
> - Cleanup of code structure, including unified `goto` labels for better
> readability and maintainability, even in simple editors.

We generally say no more than 15 patches in a set. It seems like these
could easily be two sets.

Andrew