Re: [PATCH v5 0/2] kselftest: tmpfs: Add ksft macros and skip if no root

[Shuah Khan]

On 11/12/24 07:30, Shivam Chaudhary wrote:
> This version 5 patch series replace direct error handling methods with ksft
> macros, which provide better reporting.Currently, when the tmpfs test runs,
> it does not display any output if it passes,and if it fails
> (particularly when not run as root),it simply exits without any warning or
> message.
>
> This series of patch adds:
>
> 1. Add 'ksft_print_header()' and 'ksft_set_plan()'
>     to structure test outputs more effectively.
>
> 2. Error if not run as root.

This should be a skip - not a fail.

> 3. Replace direct error handling with 'ksft_test_result_*',
>     'ksft_exit_fail_msg' macros for better reporting.


> v4->v5:
>           - Remove unnecessary pass messages.
>           - Remove unnecessary use of KSFT_SKIP.
>           - Add appropriate use of ksft_exit_fail_msg.
>
> v4 1/2: https://lore.kernel.org/all/20241105202639.1977356-2-cvam0000@xxxxxxxxx/
> v4 2/2: https://lore.kernel.org/all/20241105202639.1977356-3-cvam0000@xxxxxxxxx/
>
> v3->v4:
>           - Start a patchset
>           - Split patch into smaller patches to make it easy to review.
>    Patch1 Replace  'ksft_test_result_skip' with 'KSFT_SKIP' during root run check.
>    Patch2 Replace  'ksft_test_result_fail' with 'KSFT_SKIP' where fail does not make sense,
>           or failure could be due to not unsupported APIs with appropriate warnings.
>
>
> v3: https://lore.kernel.org/all/20241028185756.111832-1-cvam0000@xxxxxxxxx/
>
> v2->v3:
>          - Remove extra ksft_set_plan()
>          - Remove function for unshare()
>          - Fix the comment style
> v2: https://lore.kernel.org/all/20241026191621.2860376-1-cvam0000@xxxxxxxxx/
>
> v1->v2:
>          - Make the commit message more clear.
> v1: https://lore.kernel.org/all/20241024200228.1075840-1-cvam0000@xxxxxxxxx/T/#u
>
>
> thanks
> Shivam
>
> Shivam Chaudhary (2):
>    selftests: tmpfs: Add Test-fail if not run as root
>    selftests: tmpfs: Add kselftest support to tmpfs
>
>   .../selftests/tmpfs/bug-link-o-tmpfile.c      | 60 ++++++++++++-------
>   1 file changed, 37 insertions(+), 23 deletions(-)

thanks,
-- Shuah