Re: [PATCH 4/5] net: renesas: rswitch: do not deinit disabled ports

[Jacob Keller]

On 12/2/2024 5:49 AM, Nikita Yushchenko wrote:
> In rswitch_ether_port_init_all(), only enabled ports are initialized.
> Then, rswitch_ether_port_deinit_all() shall also only deinitialize
> enabled ports.
> 
> Fixes: 3590918b5d07 ("net: ethernet: renesas: Add support for "Ethernet Switch"")
> Signed-off-by: Nikita Yushchenko <nikita.yoush@xxxxxxxxxxxxxxxxxx>
> ---

Do you happen to have any data on whether this causes any visible issues?

At a glance of the code, rswitch_ether_port_deinit_one appears to check
various pointers before doing anything and skips any real work if those
pointers aren't initialized.

Either way, this seems like a good cleanup, though it might not warrant
a fixes or net target if there is no user visible bug associated with it.

Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>

>  drivers/net/ethernet/renesas/rswitch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/renesas/rswitch.c b/drivers/net/ethernet/renesas/rswitch.c
> index 779c05b8e05f..5980084d9211 100644
> --- a/drivers/net/ethernet/renesas/rswitch.c
> +++ b/drivers/net/ethernet/renesas/rswitch.c
> @@ -1527,7 +1527,7 @@ static void rswitch_ether_port_deinit_all(struct rswitch_private *priv)
>  {
>  	unsigned int i;
>  
> -	for (i = 0; i < RSWITCH_NUM_PORTS; i++) {
> +	rswitch_for_each_enabled_port(priv, i) {
>  		phy_exit(priv->rdev[i]->serdes);
>  		rswitch_ether_port_deinit_one(priv->rdev[i]);
>  	}