Re: [PATCH -V3 RESEND] x86, tdx, memory hotplug: Check whole hot-adding memory range for TDX

From: Dan Williams
Date: Tue Dec 03 2024 - 20:42:08 EST


Dan Williams wrote:
> Drop my Reviewed-by as I now realize that my reading of the changelog
> for commit abe8dbab8f9f "x86/virt/tdx: Use all system memory when
> initializing TDX module as TDX memory", and the presence of the
> "is_tdx_memory()" helper lead me astray. If the changelog had said "This
> approach requires *but does not validate* all memblock memory
> regions...", I might have been spared.
>
> Until the new "convertible memory ranges" (CMR) enabling [1] is settled the
> kernel just takes on faith that anything memblock thinks is memory is
> TDX compatible.

Missed a link:

https://lore.kernel.org/b152bd39f9b235d5b20b8579a058a7f2bdbc111d.1730118186.git.kai.huang@xxxxxxxxx