Re: [PATCH] net: simplify resource acquisition + ioremap

From: Vincent Mailhol
Date: Tue Dec 03 2024 - 23:38:02 EST


Hi Rosen,

Thanks for the patch!

On Wed. 4 Dec. 2024 at 08:13, Rosen Penev <rosenp@xxxxxxxxx> wrote:
> get resource + request_mem_region + ioremap can all be done by a single
> function.
>
> Replace them with devm_platform_get_and_ioremap_resource or\
> devm_platform_ioremap_resource where res is not used.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>
> ---
> drivers/net/can/sja1000/sja1000_platform.c | 15 ++--------

For the can driver only:

Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx> # sja1000_platform.c

> drivers/net/ethernet/freescale/fman/fman.c | 35 +++++-----------------
> drivers/net/ethernet/lantiq_etop.c | 25 ++--------------
> drivers/net/mdio/mdio-octeon.c | 25 +++-------------
> 4 files changed, 17 insertions(+), 83 deletions(-)