Re: [PATCH v2] Bluetooth: qca: Support downloading board ID specific NVM for WCN6855

[quic_zijuhu]

On 11/16/2024 11:49 PM, Zijun Hu wrote:
> For WCN6855, board ID specific NVM needs to be downloaded once board ID
> is available, but the default NVM is always downloaded currently, and
> the wrong NVM causes poor RF performance which effects user experience.
> 

Hi Luiz,

could you please code review for this change ?

several types of product in market need this fix, hope it will go to
mainline as early as possible.

sorry for this noise.

> Fix by downloading board ID specific NVM if board ID is available.
> 
> Cc: Bjorn Andersson <bjorande@xxxxxxxxxxx>
> Cc: Aiqun Yu (Maria) <quic_aiquny@xxxxxxxxxxx>
> Cc: Cheng Jiang <quic_chejiang@xxxxxxxxxxx>
> Cc: Johan Hovold <johan@xxxxxxxxxx>
> Cc: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> Cc: Steev Klimaszewski <steev@xxxxxxxx>
> Cc: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> Fixes: 095327fede00 ("Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855")
> Cc: stable@xxxxxxxxxxxxxxx # 6.4
> Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> Tested-by: Steev Klimaszewski <steev@xxxxxxxx>
> Tested-by: Jens Glathe <jens.glathe@xxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> ---
> Thank you Paul, Jens, Steev, Johan, Luiz for code review, various
> verification, comments and suggestions. these comments and suggestions
> are very good, and all of them are taken by this v2 patch.
> 
> Regarding the variant 'g', sorry for that i can say nothing due to
> confidential information (CCI), but fortunately, we don't need to
> care about its difference against one without 'g' from BT host
> perspective, qca_get_hsp_nvm_name_generic() shows how to map BT chip
> to firmware.
> 
> I will help to backport it to LTS kernels ASAP once this commit
> is mainlined.
> ---
> Changes in v2:
> - Correct subject and commit message
> - Temporarily add nvm fallback logic to speed up backport.
> — Add fix/stable tags as suggested by Luiz and Johan
> - Link to v1: https://lore.kernel.org/r/20241113-x13s_wcn6855_fix-
> v1-1-15af0aa2549c@xxxxxxxxxxx
> ---