Re: [PATCH v2 2/9] coresight-etm4x: change etmv4_drvdata spinlock type to raw_spinlock_t
From: kernel test robot
Date: Wed Dec 04 2024 - 01:43:20 EST
Hi Yeoreum,
kernel test robot noticed the following build errors:
[auto build test ERROR on soc/for-next]
[also build test ERROR on linus/master v6.13-rc1 next-20241128]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yeoreum-Yun/coresight-change-coresight_device-lock-type-to-raw_spinlock_t/20241203-203214
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link: https://lore.kernel.org/r/20241203114942.697188-3-yeoreum.yun%40arm.com
patch subject: [PATCH v2 2/9] coresight-etm4x: change etmv4_drvdata spinlock type to raw_spinlock_t
config: arm64-randconfig-001-20241204 (https://download.01.org/0day-ci/archive/20241204/202412041452.KCrCJWWm-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241204/202412041452.KCrCJWWm-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412041452.KCrCJWWm-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
drivers/hwtracing/coresight/coresight-etm4x-core.c: In function 'etm4_starting_cpu':
>> drivers/hwtracing/coresight/coresight-etm4x-core.c:1666:19: error: passing argument 1 of 'spin_lock' from incompatible pointer type [-Wincompatible-pointer-types]
1666 | spin_lock(&etmdrvdata[cpu]->spinlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
In file included from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/slab.h:16,
from include/linux/resource_ext.h:11,
from include/linux/acpi.h:13,
from drivers/hwtracing/coresight/coresight-etm4x-core.c:6:
include/linux/spinlock.h:349:51: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct raw_spinlock *'}
349 | static __always_inline void spin_lock(spinlock_t *lock)
| ~~~~~~~~~~~~^~~~
>> drivers/hwtracing/coresight/coresight-etm4x-core.c:1672:21: error: passing argument 1 of 'spin_unlock' from incompatible pointer type [-Wincompatible-pointer-types]
1672 | spin_unlock(&etmdrvdata[cpu]->spinlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
include/linux/spinlock.h:389:53: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct raw_spinlock *'}
389 | static __always_inline void spin_unlock(spinlock_t *lock)
| ~~~~~~~~~~~~^~~~
drivers/hwtracing/coresight/coresight-etm4x-core.c: In function 'etm4_dying_cpu':
drivers/hwtracing/coresight/coresight-etm4x-core.c:1681:19: error: passing argument 1 of 'spin_lock' from incompatible pointer type [-Wincompatible-pointer-types]
1681 | spin_lock(&etmdrvdata[cpu]->spinlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
include/linux/spinlock.h:349:51: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct raw_spinlock *'}
349 | static __always_inline void spin_lock(spinlock_t *lock)
| ~~~~~~~~~~~~^~~~
drivers/hwtracing/coresight/coresight-etm4x-core.c:1684:21: error: passing argument 1 of 'spin_unlock' from incompatible pointer type [-Wincompatible-pointer-types]
1684 | spin_unlock(&etmdrvdata[cpu]->spinlock);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| raw_spinlock_t * {aka struct raw_spinlock *}
include/linux/spinlock.h:389:53: note: expected 'spinlock_t *' {aka 'struct spinlock *'} but argument is of type 'raw_spinlock_t *' {aka 'struct raw_spinlock *'}
389 | static __always_inline void spin_unlock(spinlock_t *lock)
| ~~~~~~~~~~~~^~~~
vim +/spin_lock +1666 drivers/hwtracing/coresight/coresight-etm4x-core.c
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 1660
58eb457be0283d drivers/hwtracing/coresight/coresight-etm4x.c Sebastian Andrzej Siewior 2016-07-13 1661 static int etm4_starting_cpu(unsigned int cpu)
58eb457be0283d drivers/hwtracing/coresight/coresight-etm4x.c Sebastian Andrzej Siewior 2016-07-13 1662 {
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 1663 if (!etmdrvdata[cpu])
58eb457be0283d drivers/hwtracing/coresight/coresight-etm4x.c Sebastian Andrzej Siewior 2016-07-13 1664 return 0;
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 1665
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 @1666 spin_lock(&etmdrvdata[cpu]->spinlock);
6d7651015c16e1 drivers/hwtracing/coresight/coresight-etm4x.c Andrew Murray 2019-08-29 1667 if (!etmdrvdata[cpu]->os_unlock)
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 1668 etm4_os_unlock(etmdrvdata[cpu]);
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 1669
c95c2733e5feb1 drivers/hwtracing/coresight/coresight-etm4x-core.c James Clark 2024-01-29 1670 if (coresight_get_mode(etmdrvdata[cpu]->csdev))
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 1671 etm4_enable_hw(etmdrvdata[cpu]);
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 @1672 spin_unlock(&etmdrvdata[cpu]->spinlock);
58eb457be0283d drivers/hwtracing/coresight/coresight-etm4x.c Sebastian Andrzej Siewior 2016-07-13 1673 return 0;
58eb457be0283d drivers/hwtracing/coresight/coresight-etm4x.c Sebastian Andrzej Siewior 2016-07-13 1674 }
2e1cdfe184b520 drivers/hwtracing/coresight/coresight-etm4x.c Pratik Patel 2015-05-13 1675
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki