Re: [PATCH v3 04/13] rust: hrtimer: implement `TimerPointer` for `Arc`

From: Andreas Hindborg
Date: Wed Dec 04 2024 - 08:42:01 EST


"Miguel Ojeda" <miguel.ojeda.sandonis@xxxxxxxxx> writes:

> On Wed, Nov 20, 2024 at 4:52 PM Andreas Hindborg <a.hindborg@xxxxxxxxxx> wrote:
>>
>> No particular reason. It is often easier to rebase things around when
>> they are on their own line.
>>
>> Are there any code guidelines to follow on this?
>
> Not yet -- we have a mixture of styles, though we typically don't go
> to the item-level like in this patch, and instead have done it closer
> to the "Crate" or "Module" styles.

What is the rationale behind this bias? Perhaps we should do a pros/cons
list before settling on a style.

It is arguably easier to merge and rebase when using the `Item` policy.


Best regards,
Andreas Hindborg