Re: [PATCH v4 1/2] input: keypad: add new keypad driver for MA35D1
From: kernel test robot
Date: Wed Dec 04 2024 - 12:54:11 EST
Hi Ming-Jen,
kernel test robot noticed the following build errors:
[auto build test ERROR on dtor-input/next]
[also build test ERROR on dtor-input/for-linus hid/for-next soc/for-next linus/master v6.13-rc1 next-20241203]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Ming-Jen-Chen/input-keypad-add-new-keypad-driver-for-MA35D1/20241204-123001
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20241204021014.5083-2-mjchen0829%40gmail.com
patch subject: [PATCH v4 1/2] input: keypad: add new keypad driver for MA35D1
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20241205/202412050142.nkbl6PnK-lkp@xxxxxxxxx/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241205/202412050142.nkbl6PnK-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412050142.nkbl6PnK-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
In file included from drivers/input/keyboard/ma35d1_keypad.c:9:
In file included from include/linux/input.h:19:
In file included from include/linux/device.h:32:
In file included from include/linux/device/driver.h:21:
In file included from include/linux/module.h:19:
In file included from include/linux/elf.h:6:
In file included from arch/s390/include/asm/elf.h:181:
In file included from arch/s390/include/asm/mmu_context.h:11:
In file included from arch/s390/include/asm/pgalloc.h:18:
In file included from include/linux/mm.h:2228:
include/linux/vmstat.h:503:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
503 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
504 | item];
| ~~~~
include/linux/vmstat.h:510:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
510 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
511 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
517 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:523:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
523 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
524 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/input/keyboard/ma35d1_keypad.c:83:17: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
83 | key_event[0] = readl(keypad->mmio_base + KPI_KPE0);
| ^
drivers/input/keyboard/ma35d1_keypad.c:89:2: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
89 | writel(key_event[0], (keypad->mmio_base + KPI_KPE0));
| ^
drivers/input/keyboard/ma35d1_keypad.c:123:12: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
123 | kstatus = readl(keypad->mmio_base + KPI_STATUS);
| ^
drivers/input/keyboard/ma35d1_keypad.c:129:4: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
129 | writel(PDWAKE, (keypad->mmio_base + KPI_STATUS));
| ^
drivers/input/keyboard/ma35d1_keypad.c:148:2: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
148 | writel(val, keypad->mmio_base + KPI_CONF);
| ^
drivers/input/keyboard/ma35d1_keypad.c:159:8: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
159 | val = readl(keypad->mmio_base + KPI_KPE0) & ~ENKP;
| ^
drivers/input/keyboard/ma35d1_keypad.c:160:2: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
160 | writel(val, keypad->mmio_base + KPI_CONF);
| ^
drivers/input/keyboard/ma35d1_keypad.c:166:17: warning: array index 12 is past the end of the array (that has type 'const unsigned int[12]') [-Warray-bounds]
166 | u32 min_diff = debounce_values[NUM_SETTINGS];
| ^ ~~~~~~~~~~~~
drivers/input/keyboard/ma35d1_keypad.c:53:1: note: array 'debounce_values' declared here
53 | static const unsigned int debounce_values[NUM_SETTINGS] = {
| ^
drivers/input/keyboard/ma35d1_keypad.c:173:25: warning: array index 12 is past the end of the array (that has type 'const unsigned int[12]') [-Warray-bounds]
173 | keypad->debounce_val = debounce_register[NUM_SETTINGS];
| ^ ~~~~~~~~~~~~
drivers/input/keyboard/ma35d1_keypad.c:57:1: note: array 'debounce_register' declared here
57 | static const unsigned int debounce_register[NUM_SETTINGS] = {
| ^
drivers/input/keyboard/ma35d1_keypad.c:349:3: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
349 | writel(readl(keypad->mmio_base + KPI_CONF) | WAKEUP, keypad->mmio_base + KPI_CONF);
| ^
drivers/input/keyboard/ma35d1_keypad.c:349:10: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
349 | writel(readl(keypad->mmio_base + KPI_CONF) | WAKEUP, keypad->mmio_base + KPI_CONF);
| ^
drivers/input/keyboard/ma35d1_keypad.c:359:3: error: call to undeclared function 'writel'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
359 | writel(readl(keypad->mmio_base + KPI_CONF) & ~(WAKEUP),
| ^
drivers/input/keyboard/ma35d1_keypad.c:359:10: error: call to undeclared function 'readl'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
359 | writel(readl(keypad->mmio_base + KPI_CONF) & ~(WAKEUP),
| ^
6 warnings and 11 errors generated.
vim +/readl +83 drivers/input/keyboard/ma35d1_keypad.c
72
73 static void ma35d1_keypad_scan_matrix(struct ma35d1_keypad *keypad, unsigned int status)
74 {
75 struct input_dev *input_dev = keypad->input_dev;
76 u32 row_shift = get_count_order(keypad->kpi_col);
77 u32 *keymap = input_dev->keycode;
78 u32 code, key, index;
79 u32 key_event[4];
80 u64 pressed_keys = 0, released_keys = 0;
81
82 /* Read key event status */
> 83 key_event[0] = readl(keypad->mmio_base + KPI_KPE0);
84 key_event[1] = readl(keypad->mmio_base + KPI_KPE1);
85 key_event[2] = readl(keypad->mmio_base + KPI_KRE0);
86 key_event[3] = readl(keypad->mmio_base + KPI_KRE1);
87
88 /* Clear key event status */
89 writel(key_event[0], (keypad->mmio_base + KPI_KPE0));
90 writel(key_event[1], (keypad->mmio_base + KPI_KPE1));
91 writel(key_event[2], (keypad->mmio_base + KPI_KRE0));
92 writel(key_event[3], (keypad->mmio_base + KPI_KRE1));
93
94 pressed_keys = key_event[0] | ((u64)key_event[1] << 32);
95 released_keys = key_event[2] | ((u64)key_event[3] << 32);
96
97 /* Process pressed keys */
98 for_each_set_bit(index, (const unsigned long *)&pressed_keys, KEY_EVENT_BITS) {
99 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift);
100 key = keymap[code];
101
102 input_event(input_dev, EV_MSC, MSC_SCAN, code);
103 input_report_key(input_dev, key, 1);
104 }
105
106 /* Process released keys */
107 for_each_set_bit(index, (const unsigned long *)&released_keys, KEY_EVENT_BITS) {
108 code = MATRIX_SCAN_CODE(index / 8, (index % 8), row_shift);
109 key = keymap[code];
110
111 input_event(input_dev, EV_MSC, MSC_SCAN, code);
112 input_report_key(input_dev, key, 0);
113 }
114
115 input_sync(input_dev);
116 }
117
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki