Re: [PATCH] dt-bindings: input: convert dlg,da7280.txt to dt-schema

[Conor Dooley]

On Wed, Dec 04, 2024 at 11:54:35AM +0100, Neil Armstrong wrote:

> +  dlg,bemf-sens-enable:
> +    type: boolean
> +    description:
> +      Enable for internal loop computations
> +
> +  dlg,freq-track-enable:
> +    type: boolean
> +    description:
> +      Enable for resonant frequency tracking
> +
> +  dlg,acc-enable:
> +    type: boolean
> +    description:
> +      Enable for active acceleration
> +
> +  dlg,rapid-stop-enable:
> +    type: boolean
> +    description:
> +      Enable for rapid stop
> +
> +  dlg,amp-pid-enable:
> +    type: boolean

Shouldn't these ones be "flag"?

> +    description:
> +      Enable for the amplitude PID
> +
> +  dlg,mem-array:
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    minItems: 100
> +    description:
> +      Customized waveform memory (patterns) data downloaded to the device during initialization
> +
> +required:
> +  - compatible

Is this right? The text binding has: compatible, reg, interrupt-parent,
and a handful of vendor properties required. I don't see a mention for
the drop in the commit message.

Cheers,
Conor.

Attachment: signature.asc
Description: PGP signature