Re: [PATCH][next] afs: remove redudant use of variable ret in afs_dir_iterate_contents

From: David Howells
Date: Wed Dec 04 2024 - 14:03:37 EST


Colin Ian King <colin.i.king@xxxxxxxxx> wrote:

> The variable ret is being initialized with 0 and is never re-assigned.
> At the end of the function the check for ret being set to -ESTALE
> is always false, so the check and the call to afs_invalidate_dir is
> redundant. Remove ret and this check and just return 0 at the end
> of the function.

This is the wrong thing to do. We need to get the error out. I'm fixing my
patch to do that.

Thanks,
David