Re: [PATCH 1/2] ttynull: Add an option to allow ttynull to be used as a console device
From: Greg Kroah-Hartman
Date: Wed Dec 04 2024 - 14:50:18 EST
On Wed, Dec 04, 2024 at 12:06:56PM -0500, n3rdopolis wrote:
> On Wednesday, December 4, 2024 10:41:44 AM EST Greg Kroah-Hartman wrote:
> > On Thu, Nov 28, 2024 at 11:15:48PM -0500, n3rdopolis wrote:
> > > Add a config option CONFIG_NULL_TTY_CONSOLE that will have ttynull be
> > > initialized by console_initcall() and selected as a possible console
> > > device.
> > > Signed-off-by: n3rdopolis <bluescreen_avenger@xxxxxxxxxxx>
> >
> > Meta-comments, we need a blank line before the s-o-b line, AND we need a
> > real name here, sorry. I can't do anything with these (including
> > reviewing them), until that happens.
> >
> Oh, I thought that I didn't need a real name
>
> I found a recent thread that seems like it suggests that I thought
> https://lore.kernel.org/all/20241121165806.476008-40-alex.bennee@xxxxxxxxxx/[1]
> https://drewdevault.com/2023/10/31/On-real-names.html[2]
> Or do I need to wait for that change to the guideline be merged?
That change has been merged a long time ago, but as far as I can tell,
this signed-off-by you used here does not meet this category.
thanks,
greg k-h