Re: [PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions

From: Martin K. Petersen
Date: Wed Dec 04 2024 - 14:57:31 EST

Next message: James Houghton: "[PATCH v1 03/13] KVM: Allow late setting of KVM_MEM_USERFAULT on guest_memfd memslot"
Previous message: Sasha Levin: "[PATCH AUTOSEL 6.1 03/15] tracing: Use atomic64_inc_return() in trace_clock_counter()"
In reply to: Thomas Weißschuh: "[PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions"
Next in thread: Tzung-Bi Shih: "Re: [PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Thomas,

> Using the macro saves some lines of code and prepares the attributes for
> the general constifications of struct bin_attributes.
>
> While at it also constify the callback parameters.

Looks OK to me.

Reviewed-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

--
Martin K. Petersen Oracle Linux Engineering

Next message: James Houghton: "[PATCH v1 03/13] KVM: Allow late setting of KVM_MEM_USERFAULT on guest_memfd memslot"
Previous message: Sasha Levin: "[PATCH AUTOSEL 6.1 03/15] tracing: Use atomic64_inc_return() in trace_clock_counter()"
In reply to: Thomas Weißschuh: "[PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions"
Next in thread: Tzung-Bi Shih: "Re: [PATCH 5/5] scsi: arcmsr: Use BIN_ATTR_ADMIN_WO() for bin_attribute definitions"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]