RE: [PATCH v2] arm64: zynqmp: add clock-output-names property in clock nodes

[Thangaraj, Senthil Nathan]

> -----Original Message-----
> From: Naman Trivedi <naman.trivedimanojbhai@xxxxxxx>
> Sent: Friday, November 22, 2024 1:57 AM
> To: robh@xxxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>;
> krzk+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; Thangaraj, Senthil Nathan
> <SenthilNathan.Thangaraj@xxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH v2] arm64: zynqmp: add clock-output-names property in clock
> nodes
> 
> Add clock-output-names property to clock nodes, so that the resulting clock name
> do not change when clock node name is changed.
> Also, replace underscores with hyphens in the clock node names as per dt-schema
> rule.
> 
> Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@xxxxxxx>
> ---
> v1: https://lore.kernel.org/all/c5d6effa-bdcf-49e3-a4bf-3713db889b70@xxxxxxxxxx
> Changes v1 -> v2:
> - Fix the clock node names by replacing underscore with hyphen.
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> b/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> index 60d1b1acf9a0..385fed8a852a 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> @@ -10,39 +10,44 @@
> 
>  #include <dt-bindings/clock/xlnx-zynqmp-clk.h>
>  / {
> -	pss_ref_clk: pss_ref_clk {
> +	pss_ref_clk: pss-ref-clk {
>  		bootph-all;
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
>  		clock-frequency = <33333333>;
> +		clock-output-names = "pss_ref_clk";
>  	};
> 
> -	video_clk: video_clk {
> +	video_clk: video-clk {
>  		bootph-all;
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
>  		clock-frequency = <27000000>;
> +		clock-output-names = "video_clk";
>  	};
> 
> -	pss_alt_ref_clk: pss_alt_ref_clk {
> +	pss_alt_ref_clk: pss-alt-ref-clk {
>  		bootph-all;
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
>  		clock-frequency = <0>;
> +		clock-output-names = "pss_alt_ref_clk";
>  	};
> 
> -	gt_crx_ref_clk: gt_crx_ref_clk {
> +	gt_crx_ref_clk: gt-crx-ref-clk {
>  		bootph-all;
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
>  		clock-frequency = <108000000>;
> +		clock-output-names = "gt_crx_ref_clk";
>  	};
> 
> -	aux_ref_clk: aux_ref_clk {
> +	aux_ref_clk: aux-ref-clk {
>  		bootph-all;
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
>  		clock-frequency = <27000000>;
> +		clock-output-names = "aux_ref_clk";
>  	};
>  };
> 
> --
> 2.25.1

Acked-by: Senthil Nathan Thangaraj <senthilnathan.thangaraj@xxxxxxx>

Thanks,
Senthil