Re: [PATCH 09/11] x86: rework CONFIG_GENERIC_CPU compiler flags
From: Arnd Bergmann
Date: Wed Dec 04 2024 - 16:00:18 EST
On Wed, Dec 4, 2024, at 18:09, Nathan Chancellor wrote:
> Hi Arnd,
>
> On Wed, Dec 04, 2024 at 11:30:40AM +0100, Arnd Bergmann wrote:
> ...
>> +++ b/arch/x86/Kconfig.cpu
>> +config X86_64_V1
>> +config X86_64_V2
>> +config X86_64_V3
> ...
>> +++ b/arch/x86/Makefile
>> + cflags-$(CONFIG_MX86_64_V1) += -march=x86-64
>> + cflags-$(CONFIG_MX86_64_V2) += $(call cc-option,-march=x86-64-v2,-march=x86-64)
>> + cflags-$(CONFIG_MX86_64_V3) += $(call cc-option,-march=x86-64-v3,-march=x86-64)
> ...
>> + rustflags-$(CONFIG_MX86_64_V1) += -Ctarget-cpu=x86-64
>> + rustflags-$(CONFIG_MX86_64_V2) += -Ctarget-cpu=x86-64-v2
>> + rustflags-$(CONFIG_MX86_64_V3) += -Ctarget-cpu=x86-64-v3
>
> There appears to be an extra 'M' when using these CONFIGs in Makefile,
> so I don't think this works as is?
Fixed now by adding the 'M' in the Kconfig file, thanks for
noticing it.
Arnd