Re: [PATCH v1] perf script python: Improve physical mem type resolution

[Arnaldo Carvalho de Melo]

On Tue, Nov 19, 2024 at 03:05:41PM -0500, Liang, Kan wrote:
> On 2024-11-19 1:01 p.m., Ian Rogers wrote:
> > After:
> > ```
> > Event: mem_inst_retired.any:P
> > Memory type                                    count  percentage
> > ----------------------------------------  ----------  ----------
> > 100000000-105f7fffff : System RAM               9460        90.5
> >   841400000-8416599ff : Kernel data               45         0.4
> >   840800000-8412a6fff : Kernel rodata             19         0.2
> >   841ebe000-8423fffff : Kernel bss                12         0.1
> > 0-fff : Reserved                                 998         9.5
> > ```

> > The code has been updated to python 3 with type hints and resolving
> > issues reported by mypy and pylint. Tabs are swapped to spaces as
> > preferred in PEP8, because most lines of code were modified (of this
> > small file) and this makes pylint significantly less noisy.
 
> Thanks Ian. A very nice improvement!
 
> Acked-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

Thanks, tested on a:

  root@number:/tmp# grep -m1 "model name" /proc/cpuinfo 
  model name	: Intel(R) Core(TM) i7-14700K
  root@number:/tmp#

and applied to perf-tools-next:

      root@number:/tmp# perf script mem-phys-addr -a find /
      <SNIP>
      /bin
      /lib
      /lib64
      /sbin
      Warning:
      744 out of order events recorded.
      Event: cpu_core/mem_inst_retired.all_loads/P
      Memory type                                    count  percentage
      ----------------------------------------  ----------  ----------
      100000000-8bfbfffff : System RAM              364561        76.5
        621400000-6223a6fff : Kernel rodata          10474         2.2
        622400000-62283d4bf : Kernel data             4828         1.0
        623304000-6237fffff : Kernel bss              1063         0.2
        620000000-6213fffff : Kernel code               98         0.0
      0-fff : Reserved                              111480        23.4
      100000-2b0ca017 : System RAM                     337         0.1
      2fbad000-30d92fff : System RAM                    44         0.0
      2c79d000-2fbabfff : System RAM                    30         0.0
      30d94000-316d5fff : System RAM                    16         0.0
      2b131a58-2c71dfff : System RAM                     7         0.0
      root@number:/tmp#

- Arnaldo