Re: [PATCH net v4] ethtool: Fix wrong mod state in case of verbose and no_mask bitset

From: patchwork-bot+netdevbpf
Date: Wed Dec 04 2024 - 22:20:25 EST


Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@xxxxxxxxxx>:

On Mon, 2 Dec 2024 16:33:57 +0100 you wrote:
> A bitset without mask in a _SET request means we want exactly the bits in
> the bitset to be set. This works correctly for compact format but when
> verbose format is parsed, ethnl_update_bitset32_verbose() only sets the
> bits present in the request bitset but does not clear the rest. The commit
> 6699170376ab ("ethtool: fix application of verbose no_mask bitset") fixes
> this issue by clearing the whole target bitmap before we start iterating.
> The solution proposed brought an issue with the behavior of the mod
> variable. As the bitset is always cleared the old value will always
> differ to the new value.
>
> [...]

Here is the summary with links:
- [net,v4] ethtool: Fix wrong mod state in case of verbose and no_mask bitset
https://git.kernel.org/netdev/net/c/910c4788d615

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html