Re: [RFC PATCH] resource: Fix CXL node not populated issue

From: Raghavendra K T
Date: Thu Dec 05 2024 - 00:45:29 EST




On 12/4/2024 10:14 AM, Raghavendra K T wrote:



(*) in general fixes are better than reverts, but depends on the timing in
     the release cycle the revert may be the only option.

I don't think that the timing is so tight that we should not work on
proper fix firstly.  I'm trying to work with the reporter on this.

I agree on this, please do.

BTW, the commit b4afe4183ec7 ("resource: fix region_intersects() vs
add_memory_driver_managed()") fixed a security related bug.  The bug
weakened the protection to prevent users read/write system memory via
/dev/mem.  So, IMO, we need to be more careful about this.

My point was that the regression is obvious and it needs to be fixed.
That's all. Revert is a last resort in this sense.


I agree in general to both of your comment. (i.e. since this bisected
commit had security fix, we shall try to get better fix than a close to
revert).

 I am trying to work on this, but it is a bit slow on my side.


I will try to get a fix that retains old bugfix and works well for me too.
Since it is reproduced only on this shared system, I will get hold of
this system next week, and work towards a fix.

Thanks and Regards
- Raghu