Re: [PATCH v1 1/1] pref/x86/rapl: Remove unused function
From: Andy Shevchenko
Date: Thu Dec 05 2024 - 02:45:11 EST
On Wed, Dec 04, 2024 at 03:56:03PM -0800, Ian Rogers wrote:
> On Mon, Dec 2, 2024 at 10:28 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > get_rapl_pmu_cpumask() is unused, it prevents kernel builds
> > with clang, `make W=1` and CONFIG_WERROR=y:
> >
> > arch/x86/events/rapl.c:165:37: error: unused function 'get_rapl_pmu_cpumask' [-Werror,-Wunused-function]
> >
> > Fix this by removing unused function.
> >
> > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> > inline functions for W=1 build").
> >
> > Fixes: 9e9af8bbb5f9 ("perf/x86/rapl: Clean up cpumask and hotplug")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
>
> nit: s/pref/perf/ in the commit message title
Thanks, the analogue change is already in the perf tree. Just hadn't made the
rc1.
--
With Best Regards,
Andy Shevchenko