Re: [PATCH v4 4/4] power: sequencing: qcom-wcn: add support for the WCN6750 PMU

[Krzysztof Kozlowski]

On Wed, Dec 04, 2024 at 06:47:06PM +0530, Janaki Ramaiah Thota wrote:
> Enable support for controlling the power-up sequence of the PMU inside
> the WCN6750 model.
> 
> Signed-off-by: Janaki Ramaiah Thota <quic_janathot@xxxxxxxxxxx>
> ---
>  drivers/power/sequencing/pwrseq-qcom-wcn.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/drivers/power/sequencing/pwrseq-qcom-wcn.c b/drivers/power/sequencing/pwrseq-qcom-wcn.c
> index 682a9beac69e..e38da79f0ada 100644
> --- a/drivers/power/sequencing/pwrseq-qcom-wcn.c
> +++ b/drivers/power/sequencing/pwrseq-qcom-wcn.c
> @@ -293,6 +293,24 @@ static const struct pwrseq_qcom_wcn_pdata pwrseq_wcn6855_of_data = {
>  	.targets = pwrseq_qcom_wcn6855_targets,
>  };
>  
> +static const char *const pwrseq_wcn6750_vregs[] = {
> +	"vddaon",
> +	"vddasd",
> +	"vddpmu",
> +	"vddrfa0p8",
> +	"vddrfa1p2",
> +	"vddrfa1p7",
> +	"vddrfa2p2",
> +};
> +
> +static const struct pwrseq_qcom_wcn_pdata pwrseq_wcn6750_of_data = {
> +	.vregs = pwrseq_wcn6750_vregs,
> +	.num_vregs = ARRAY_SIZE(pwrseq_wcn6750_vregs),
> +	.pwup_delay_ms = 50,
> +	.gpio_enable_delay_ms = 5,
> +	.targets = pwrseq_qcom_wcn_targets,
> +};
> +
>  static const char *const pwrseq_wcn7850_vregs[] = {
>  	"vdd",
>  	"vddio",
> @@ -431,6 +449,10 @@ static const struct of_device_id pwrseq_qcom_wcn_of_match[] = {
>  		.compatible = "qcom,wcn7850-pmu",
>  		.data = &pwrseq_wcn7850_of_data,
>  	},
> +	{
> +		.compatible = "qcom,wcn6750-pmu",

Don't stuff things at the end of lists. Keep proper order instead.

Best regards,
Krzysztof