Re: [PATCH] fs/ceph/file: fix memory leaks in __ceph_sync_read()
From: Max Kellermann
Date: Thu Dec 05 2024 - 03:32:53 EST
On Fri, Nov 29, 2024 at 9:06 AM Max Kellermann <max.kellermann@xxxxxxxxx> wrote:
>
> On Thu, Nov 28, 2024 at 1:18 PM Alex Markuze <amarkuze@xxxxxxxxxx> wrote:
> > Pages are freed in `ceph_osdc_put_request`, trying to release them
> > this way will end badly.
>
> Is there anybody else who can explain this to me?
> I believe Alex is wrong and my patch is correct, but maybe I'm missing
> something.
It's been a week. Is there really nobody who understands this piece of
code? I believe I do understand it, but my understanding conflicts
with Alex's, and he's the expert (and I'm not).