[PATCH v1 1/2] mm/page_alloc: don't use __GFP_HARDWALL when migrating pages via alloc_contig*()

From: David Hildenbrand
Date: Thu Dec 05 2024 - 03:52:44 EST


We'll migrate pages allocated by other contexts; respecting the cpuset of
the alloc_contig*() caller when allocating a migration target does not
make sense.

Drop the __GFP_HARDWALL.

Note that in an ideal world, migration code could figure out the cpuset
of the original context and take that into consideration.

Suggested-by: Vlastimil Babka <vbabka@xxxxxxx>
Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
---
mm/page_alloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 48a291c485df..acadfcf654fd 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6410,11 +6410,11 @@ static int __alloc_contig_verify_gfp_mask(gfp_t gfp_mask, gfp_t *gfp_cc_mask)
* page range. Migratable pages are movable, __GFP_MOVABLE is implied
* for them.
*
- * Traditionally we always had __GFP_HARDWALL|__GFP_RETRY_MAYFAIL set,
- * keep doing that to not degrade callers.
+ * Traditionally we always had __GFP_RETRY_MAYFAIL set, keep doing that
+ * to not degrade callers.
*/
*gfp_cc_mask = (gfp_mask & (reclaim_mask | cc_action_mask)) |
- __GFP_HARDWALL | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL;
+ __GFP_MOVABLE | __GFP_RETRY_MAYFAIL;
return 0;
}

--
2.47.1