Re: [PATCH v4 1/4] dt-bindings: firmware: imx: add nvmem phandle
From: Krzysztof Kozlowski
Date: Thu Dec 05 2024 - 03:59:40 EST
On Thu, Dec 05, 2024 at 05:56:32AM +0100, Vabhav Sharma wrote:
> nvmem phandle is required by secvio driver to
> read fuse.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Vabhav Sharma <vabhav.sharma@xxxxxxx>
> ---
> Documentation/devicetree/bindings/firmware/fsl,scu.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> index 557e524786c2..c88d9c2dac24 100644
> --- a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> +++ b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> @@ -112,6 +112,9 @@ properties:
> - const: rx2
> - const: rx3
> - const: gip3
Unresolved comment. I would normally add conditional ack, but this is
second time you ignore comments, so I don't trust you on that. Sad that
such trivial things will require respin.
> + nvmem:
> + description:
> + phandle of NVMEM controller provided by the SCU
Best regards,
Krzysztof