Re: [PATCH V4 RESEND 2/3] dt-bindings: rtc: Add support for ATCRTC100 RTC

From: CL Wang
Date: Thu Dec 05 2024 - 04:16:34 EST


Hi Rob,

Thank you for your review and comments.

I will include the reviewer's tag in the next version of the patch.
As you mentioned, if a tag is received and a resend is necessary,
I will include the tags and update the revision to v5.

Thank you again for your reminder.

Best regards,
CL

On Tue, Dec 03, 2024 at 11:06:51AM -0600, Rob Herring wrote:
> [EXTERNAL MAIL]
>
> On Wed, Nov 27, 2024 at 10:19:38PM +0800, CL Wang wrote:
> > Document Device Tree bindings for the Andes ATCRTC100 Real-Time Clock.
> >
> > Signed-off-by: CL Wang <cl634@xxxxxxxxxxxxx>
> >
> > ---
> > Changes for v2:
> > - First version of devicetree bindings for the Andes ATCRTC100 Real-Time Clock.
> >
> > Changes for v3:
> > - Used compatible as the filename.
> > - Placed allOf after maintainers.
> > - Replaced additionalProperties: false with unevaluatedProperties: false.
> > - Added descriptions for interrupts.
> >
> > Changes for v4:
> > - Removed wakeup-source attribute.
> > ---
> > .../bindings/rtc/andestech,atcrtc100.yaml | 43 +++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/rtc/andestech,atcrtc100.yaml
>
> Missing Conor's tag from the 1st resend. If you got tags and need to
> resend, that's not a resend. You need to add the tags and it is v5.
>
> But don't just go send v5 now for that. Alexandre can add the tag.
>
> Rob