Re: [PATCH v3 1/3] dt-bindings: drm/bridge: ti-sn65dsi83: Add properties for ti,lvds-vod-swing

[Andrej Picej]

Hi Krzysztof,

On 4. 12. 24 08:54, Krzysztof Kozlowski wrote:
> On Tue, Dec 03, 2024 at 12:00:52PM +0100, Andrej Picej wrote:
> > Add properties which can be used to specify LVDS differential output
> > voltage. Since this also depends on near-end signal termination also
> > include property which sets this. LVDS differential output voltage is
> > specified with an array (min, max), which should match the one from
> > connected device.
> >
> > Signed-off-by: Andrej Picej <andrej.picej@xxxxxxxxx>
> > ---
> > Changes in v3:
> > - no change
>
>
> One version of patchset per 24h.

understood.

> > Changes in v2:
> > - move LVDS port schema to a $defs and reference it from there
> > - properties are now defined in microvolts/ohms
> > - use 1 property for data-lane and 1 for clock-lane LVDS voltage swing
> > - add 1 property which sets LVDS near-end termination
> > - since major change was done change the authorship to myself
> > ---
> >   .../bindings/display/bridge/ti,sn65dsi83.yaml | 36 +++++++++++++++++--
> >   1 file changed, 33 insertions(+), 3 deletions(-)
>
> ...
>
> >   allOf:
> >     - if:
> >         properties:
> > @@ -120,7 +150,7 @@ allOf:
> >             properties:
> >               port@1: false
> >   
> > -additionalProperties: false
> > +additionalProperties: true
>
> This cannot be true. Not explained in commit msg and this is not shared
> schema.

You are right. Will remove it in next iteration.

Best regards,
Andrej

> >   
> >   examples:
> >     - |
> > --
> > 2.34.1