Re: [PATCH v10 0/2] Add support for nuvoton ma35 nand controller

[Miquel Raynal]

Hi,

On 04/12/2024 at 02:51:27 GMT, Hui-Ping Chen <hpchen0nvt@xxxxxxxxx> wrote:

> This patch series adds the mtd nand driver for the nuvoton ma35 ARMv8 SoC.
> It includes DT binding documentation and the ma35 mtd nand driver.
>
> v10:
>   - Update ma35d1 mtd nand driver
>     - Add unsupported write page handling.

I was about to apply it but...

    [31m●[0m checkpatch.pl: 117: WARNING: please write a help paragraph that fully describes the config symbol
    [31m●[0m checkpatch.pl: 141: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
    [31m●[0m checkpatch.pl: 348: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 352: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 352: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 429: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 465: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 465: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 466: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 466: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 467: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 467: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 468: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 468: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 479: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 479: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 481: CHECK: spaces preferred around that '*' (ctx:VxV)
    [31m●[0m checkpatch.pl: 481: CHECK: spaces preferred around that '+' (ctx:VxV)
    [31m●[0m checkpatch.pl: 514: CHECK: Unbalanced braces around else statement
    [31m●[0m checkpatch.pl: 611: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 650: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 665: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 675: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 689: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 699: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 715: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 756: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 805: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 935: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 950: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 953: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 975: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 1001: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 1018: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 1131: CHECK: Alignment should match open parenthesis
    [31m●[0m checkpatch.pl: 1159: WARNING: DT compatible string "nuvoton,ma35d1-nand" appears un-documented -- check ./Documentation/devicetree/bindings/

Please fix these warnings and checks.

You might want to use --strict by default.

Thanks,
Miquèl