Re: [RFC PATCH 19/21] platform-x86: Rename alienare-wmi

[Ilpo Järvinen]

On Wed, 4 Dec 2024, Kurt Borja wrote:

> In order to eventually split the module:
> 
> Rename alienware-wmi.c -> alienware-wmi-base.c
> 
> And modify MAINTAINERS accordingly.
> 
> Signed-off-by: Kurt Borja <kuurtb@xxxxxxxxx>
> ---
>  MAINTAINERS                                                    | 3 ++-
>  drivers/platform/x86/dell/Makefile                             | 1 +
>  .../x86/dell/{alienware-wmi.c => alienware-wmi-base.c}         | 0
>  3 files changed, 3 insertions(+), 1 deletion(-)
>  rename drivers/platform/x86/dell/{alienware-wmi.c => alienware-wmi-base.c} (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3809931b9240..a4d02074dd91 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -787,7 +787,8 @@ ALIENWARE WMI DRIVER
>  L:	Dell.Client.Kernel@xxxxxxxx
>  S:	Maintained
>  F:	Documentation/wmi/devices/alienware-wmi.rst
> -F:	drivers/platform/x86/dell/alienware-wmi.c
> +F:	drivers/platform/x86/dell/alienware-wmi-*
> +F:	drivers/platform/x86/dell/alienware-wmi.*

Why not F: drivers/platform/x86/dell/alienware-wmi*

?

>  ALLEGRO DVT VIDEO IP CORE DRIVER
>  M:	Michael Tretter <m.tretter@xxxxxxxxxxxxxx>
> diff --git a/drivers/platform/x86/dell/Makefile b/drivers/platform/x86/dell/Makefile
> index 79d60f1bf4c1..5e7496aeb070 100644
> --- a/drivers/platform/x86/dell/Makefile
> +++ b/drivers/platform/x86/dell/Makefile
> @@ -5,6 +5,7 @@
>  #
>  
>  obj-$(CONFIG_ALIENWARE_WMI)		+= alienware-wmi.o
> +alienware-wmi-objs			:= alienware-wmi-base.o
>  obj-$(CONFIG_DCDBAS)			+= dcdbas.o
>  obj-$(CONFIG_DELL_LAPTOP)		+= dell-laptop.o
>  obj-$(CONFIG_DELL_RBTN)			+= dell-rbtn.o
> diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi-base.c
> similarity index 100%
> rename from drivers/platform/x86/dell/alienware-wmi.c
> rename to drivers/platform/x86/dell/alienware-wmi-base.c
> 

-- 
 i.