Re: [PATCH v4 3/3] hwmon: (pmbus/tps25990): add initial support

[Kees Bakker]

Op 02-12-2024 om 11:28 schreef Jerome Brunet:
> Add initial support for the Texas Instruments TPS25990 eFuse.
> This adds the basic PMBUS telemetry support for the device.
>
> Tested-by: Vaishnav Achath <vaishnav.a@xxxxxx>
> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx>
> ---
>   Documentation/hwmon/index.rst    |   1 +
>   Documentation/hwmon/tps25990.rst | 148 +++++++++++++
>   MAINTAINERS                      |   2 +
>   drivers/hwmon/pmbus/Kconfig      |  17 ++
>   drivers/hwmon/pmbus/Makefile     |   1 +
>   drivers/hwmon/pmbus/tps25990.c   | 437 +++++++++++++++++++++++++++++++++++++++
>   6 files changed, 606 insertions(+)
>
> [...]
> diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..0a267014c88997fca5e83b2ec974a0d521808512
> [...]
> +	case PMBUS_VIRT_READ_IIN_MAX:
> +		return TPS25990_READ_IIN_PEAK;
> +		ret = pmbus_read_word_data(client, page, phase,
> +					   TPS25990_READ_IIN_PEAK);
> +		break;
> [...]
Is the return intended? Or some left-over debug code?
--
Kees