Re: [PATCH v6 drm-dp 4/5] drm/hisilicon/hibmc: separate struct of vdac

From: Dmitry Baryshkov
Date: Thu Dec 05 2024 - 18:27:57 EST


On Mon, Dec 02, 2024 at 09:13:21PM +0800, Yongbang Shi wrote:
> From: baihan li <libaihan@xxxxxxxxxx>
>
> Refactored struct hibmc_drm_private to separate VGA module from
> generic struct.
>
> Signed-off-by: Baihan Li <libaihan@xxxxxxxxxx>
> Signed-off-by: Yongbang Shi <shiyongbang@xxxxxxxxxx>
> ---
> ChangeLog:
> v3 -> v4:
> - separating hibmc_vdac and hibmc_dp changes into separate patche, suggested by Dmitry Baryshkov.
> v2 -> v3:
> - fix build errors reported by kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202410251136.1m7BlR68-lkp@xxxxxxxxx/
> v1 -> v2:
> - deleting struct dp_mode and dp_mode_cfg function, suggested by Dmitry Baryshkov.
> - modifying drm_simple_encoder_init function, suggested by Dmitry Baryshkov.
> - refactoring struct hibmc_connector, suggested by Dmitry Baryshkov.
> - withdrawing the modification in hibmc_kms_init, suggested by Dmitry Baryshkov.
> v1:https://lore.kernel.org/all/20240930100610.782363-1-shiyongbang@xxxxxxxxxx/
> ---
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 16 ++++----
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 41 +++++++++----------
> .../gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 20 ++++-----
> 3 files changed, 38 insertions(+), 39 deletions(-)
>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>

--
With best wishes
Dmitry