Re: [PATCH v4 2/2] arm64: dts: qcom: qcs8300-ride: enable ethernet0

[Yijie Yang]

On 2024-12-06 07:39, Andrew Lunn wrote:
> > > > +&ethernet0 {
> > > > +	phy-mode = "2500base-x";
> > > > +	phy-handle = <&sgmii_phy0>;
> > >
> > > Nit picking, but your PHY clearly is not an SGMII PHY if it is using
> > > 2500base-x. I would call it just phy0, so avoiding using SGMII
> > > wrongly, which most vendors do use the name SGMII wrongly.
> >
> > Andrew, does that mean the rest of the patch looks ok?
> >
> > If so, I don't have any concerns either.
>
> Yes, this is a minor problem, the rest looks O.K, so once this is
> fixed it can be merged.
>
> 	Andrew


I will update the PHY name and pad the register in the next version.

--
Best Regards,
Yijie