Re: [PATCH V4 RESEND net-next 6/7] net: hibmcge: Add reset supported in this module
From: Jakub Kicinski
Date: Thu Dec 05 2024 - 20:59:25 EST
On Tue, 3 Dec 2024 23:01:30 +0800 Jijie Shao wrote:
> But the ethtool command already holds the rtnl lock in the dev_ethtool().
> So, the reset operation is not directly performed in
> ethtool_ops.reset() function. Instead, the reset operation
> is triggered by a scheduled task.
You can trivially factor out taking and releasing of the lock so that
ethtool path can execute just the logic inside, no?