Re: [PATCH v2 5/9] ACPI: APEI: EINJ: Enable the discovery of EINJv2 capabilities

From: kernel test robot
Date: Thu Dec 05 2024 - 22:12:03 EST


Hi Zaid,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/bleeding-edge linus/master v6.13-rc1 next-20241205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Zaid-Alali/ACPICA-Update-values-to-hex-to-follow-ACPI-specs/20241206-052420
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/20241205211854.43215-6-zaidal%40os.amperecomputing.com
patch subject: [PATCH v2 5/9] ACPI: APEI: EINJ: Enable the discovery of EINJv2 capabilities
config: arm64-randconfig-002-20241206 (https://download.01.org/0day-ci/archive/20241206/202412061056.fk2xNw7W-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241206/202412061056.fk2xNw7W-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412061056.fk2xNw7W-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/acpi/apei/einj-core.c: In function 'error_type_set':
>> drivers/acpi/apei/einj-core.c:728:35: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess]
728 | memset(einj_buf, 0, sizeof(einj_buf));
| ^


vim +728 drivers/acpi/apei/einj-core.c

721
722 static ssize_t error_type_set(struct file *file, const char __user *buf,
723 size_t count, loff_t *ppos)
724 {
725 int rc;
726 u64 val;
727
> 728 memset(einj_buf, 0, sizeof(einj_buf));
729 if (copy_from_user(einj_buf, buf, count))
730 return -EFAULT;
731
732 if (strncmp(einj_buf, "V2_", 3) == 0) {
733 if (!sscanf(einj_buf, "V2_%llx", &val))
734 return -EINVAL;
735 } else
736 if (!sscanf(einj_buf, "%llx", &val))
737 return -EINVAL;
738
739 rc = einj_validate_error_type(val);
740 if (rc)
741 return rc;
742
743 error_type = val;
744
745 return count;
746 }
747

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki