Re: [PATCH] dt-bindings: mmc: atmel,hsmci: Convert to json schema

[Dharma.B]

Hi Conor,

On 05/12/24 11:15 pm, Conor Dooley wrote:
> On Thu, Dec 05, 2024 at 03:27:02PM +0530, Dharma Balasubiramani wrote:
> 
>> +patternProperties:
>> +  "^slot@[0-9]+$":
>> +    type: object
>> +    description: A slot node representing an MMC, SD, or SDIO slot.
>> +
>> +    allOf:
>> +      - $ref: mmc-controller.yaml
>> +
>> +    properties:
>> +      reg:
>> +        description: Slot ID.
>> +        minimum: 0
>> +
>> +      bus-width:
>> +        description: Number of data lines connected to the controller.
>> +        enum: [1, 4, 8]
>> +
>> +      cd-gpios:
>> +        description: GPIO used for card detection.
>> +
>> +      cd-inverted:
>> +        type: boolean
> This type conflicts with mmc-controller.yaml, it's a flag there.

Yes, I overlooked it. I'll simply remove the type here.

> 
>> +        description: Inverts the value of the card detection GPIO.
>> +
>> +      wp-gpios:
>> +        description: GPIO used for write protection.
>> +
>> +    required:
>> +      - reg
>> +      - bus-width
>> +
>> +    unevaluatedProperties: false
> Do you mean additionalProperties: false here? You listed properties
> contained in mmc-controller.yaml which makes it seem like you're
> restricting to this subset rather than allowing all properties - but you
> need additionalProperties: false to do that.

No, I'm not restricting the properties to this subset. There are 
additional properties, such as "non-removable," "broken-cd," and 
"disable-wp," that are used in our DTS files but are not defined in the 
old text bindings. For this reason, I used `unevaluatedProperties: 
false` instead of `additionalProperties: false`. Let me know if an 
`allOf` reference to `mmc-controller` alone would be sufficient in this 
context.


-- 
With Best Regards,
Dharma B.