Re: [PATCH V2] pwm: stm32-lp: Add check for clk_enable()

[Uwe Kleine-König]

On Thu, Dec 05, 2024 at 08:26:05PM -0500, Mingwei Zheng wrote:
> Add check for the return value of clk_enable() to catch the potential
> error.
> 
> Fixes: e70a540b4e02 ("pwm: Add STM32 LPTimer PWM driver")
> Signed-off-by: Mingwei Zheng <zmw12306@xxxxxxxxx>
> Signed-off-by: Jiasheng Jiang <jiashengjiangcool@xxxxxxxxx>

In reply to (implicit) v1 you wrote:
> We detected this through static analysis, instead of actually hit.

Would be nice to mention the tool that actually found it in the commit
log.

Otherwise I'm happy with that change now.

Given the issue is old (the offending commit is in v4.14-rc1), I'd note
send it as a fix before v4.14. I'd send it along however if something
more urgent pops up.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature