Re: [PATCH v2 06/10] perf/amd/ibs: Add pmu specific minimum period

[Ingo Molnar]

* Ravi Bangoria <ravi.bangoria@xxxxxxx> wrote:

> 0x10 is the minimum sample period for IBS Fetch and 0x90 for IBS Op.
> Current IBS pmu driver uses 0x10 for both the pmus, which is incorrect.
> Fix it by adding pmu specific minimum period values in struct perf_ibs.
> 
> Also, bail out opening a 'sample period mode' event if the user requested
> sample period is less than pmu supported minimum value. For a 'freq mode'
> event, start calibrating sample period from pmu specific minimum period.

Could you please capitalize PMU consistently, like the rest of the code 
does, both in code comments and in changelogs?

It's "PMU" and "PMUs", not "pmu" and "pmus". The only lower case use is 
when we mention 'struct pmu' - and that should be quoted.

Thanks,

	Ingo