Re: [PATCH 2/4] arm64: dts: qcom: sm8750: Add Modem / MPSS

[Krzysztof Kozlowski]

On 06/12/2024 10:22, Krzysztof Kozlowski wrote:
> On 05/12/2024 18:34, Konrad Dybcio wrote:
>> On 22.11.2024 4:26 PM, Krzysztof Kozlowski wrote:
>>> Add nodes for the MPSS and its SMP2P.  These are compatible with earlier
>>> SM8650 with difference in lack of fifth memory region for Qlink Logging.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>>> ---
>>
>> [...]
>>
>>> +
>>> +		remoteproc_mpss: remoteproc@4080000 {
>>> +			compatible = "qcom,sm8750-mpss-pas";
>>> +			reg = <0x0 0x04080000 0x0 0x4040>;
>>
>> This also seems to be 0x100000-long
> 
> Oh, we all love to copy code, starting from sm8150, I think. Depends
> which block we actually assign here - this should be 0x10000 (downstream
> DTS) or 0x100000.
> 
> Older PIL remoteproc loaders (qcom_q6v5_adsp.c) seem to access only the
> smaller 0x10000 region.

SM8150 had it correct - 4040. All others are copy-paste. I'll do some
tests and send patches.

Best regards,
Krzysztof