RE: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support and 1588 optional flag in Microchip phys

[Divya.Koppera]

Hi Andrew,

Thanks for your comments.

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Thursday, December 5, 2024 8:06 PM
> To: Divya Koppera - I30481 <Divya.Koppera@xxxxxxxxxxxxx>
> Cc: Arun Ramadoss - I17769 <Arun.Ramadoss@xxxxxxxxxxxxx>;
> UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>; hkallweit1@xxxxxxxxx;
> linux@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> kuba@xxxxxxxxxx; pabeni@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; richardcochran@xxxxxxxxx;
> vadim.fedorenko@xxxxxxxxx
> Subject: Re: [PATCH net-next v5 3/5] net: phy: Kconfig: Add ptp library support
> and 1588 optional flag in Microchip phys
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> > > And has Microchip finial decided not to keep reinventing the wheel,
> > > and there will never be a new PHY implementation? I ask, because
> > > what would its KCONFIG symbol be?
> > >
> >
> 
> > For all future Microchip PHYs PTP IP will be same, hence the
> > implementation and kconfig symbol is under MICROCHIP_PHYPTP to keep it
> > more generic.
> 
> So you would be happy for me to NACK all new PHY PTP implementations?
> 
> Are you management happy with this statement?
> 
> Even if they are, i still think you need a less generic KCONFIG symbol, i doubt
> somebody somewhere in Microchip can resist making yet another PTP
> implementation.
> 

I understand your point.

I will change the Kconfig symbol to "MICROCHIP_PHY_RDS_PTP". RDS is internal code name to identify the PHY PTP IP. 

I will also change the file names, macros, and functions to reflect the internal code name as per macro.

>         Andrew

Thanks,
Divya