Re: [PATCH v5 05/20] dt-bindings: clock: imx8m-anatop: define clocks/clock-names
From: Krzysztof Kozlowski
Date: Fri Dec 06 2024 - 07:58:39 EST
On Thu, Dec 05, 2024 at 12:17:40PM +0100, Dario Binacchi wrote:
> Define clocks and clock-names properties of the anatop device node.
This we see from the diff. Say something useful, instead of repeating
subject and patch contents.
>
> Signed-off-by: Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
>
> ---
>
> (no changes since v4)
>
> Changes in v4:
> - New
>
> .../bindings/clock/fsl,imx8m-anatop.yaml | 53 ++++++++++++++++++-
> 1 file changed, 52 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> index bbd22e95b319..f439b0a94ce2 100644
> --- a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> +++ b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml
> @@ -30,22 +30,73 @@ properties:
> interrupts:
> maxItems: 1
>
> + clocks:
> + minItems: 2
> + maxItems: 3
> +
> + clock-names:
> + minItems: 2
> + maxItems: 3
> +
> '#clock-cells':
> const: 1
>
> required:
> - compatible
> - reg
> + - clocks
> + - clock-names
That's an ABI break and nothing in commit msg mentions it, nothing
explains impact or rationale behind.
> - '#clock-cells'
Best regards,
Krzysztof