Re: [PATCH] regulator: axp20x: AXP717: set ramp_delay

[Philippe Simons]

On Fri, Dec 6, 2024 at 2:44 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Dec 06, 2024 at 01:54:39PM +0100, Philippe Simons wrote:
> > On Fri, Dec 6, 2024 at 1:48 PM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> > > >  static const struct regulator_desc axp717_regulators[] = {
> > > > +     AXP_DESC_RANGES_DELAY(AXP717, DCDC1, "dcdc1", "vin1",
> > > > +                     AXP717_DCDC_OUTPUT_CONTROL, BIT(0), 640),
>
> > > This doesn't seem to match with the above - ramp_delay is in units of
> > > uV/us?
>
> > 15.625 us / 10mV = 1.5625 us/mV = 0.0015625 us/uV
> > 0.0015625^-1 = 640 uV/us
>
> Ah, yes - sorry - I typed when I did the calculation.

No problem.
BTW: this patch is critical to at least Anbernic H700 based devices.
Without it, DVFS crashes very quickly.