Re: [PATCH v4 00/15] media: i2c: ds90ub9xx: Misc fixes and improvements
From: Andy Shevchenko
Date: Fri Dec 06 2024 - 10:38:00 EST
On Fri, Dec 06, 2024 at 10:26:36AM +0200, Tomi Valkeinen wrote:
> This series fixes various small issues in the drivers, and adds a few
> things (a couple of pixel formats and a debugging feature).
>
> It also takes a few steps in adding more i2c read/write error handlings
> to the drivers, but covers only the easy places.
>
> Adding error handling to all reads/writes needs more thinking, perhaps
> adding a "ret" parameter to the calls, similar to the cci_* functions,
> or perhaps adding helpers for writing multiple registers from a given
> table. Also, in some places rolling back from an error will require
> work.
FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko